Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable RTPSParticipantImpl after removing it from RTPSDomain participants list [15313] #2892

Merged
merged 2 commits into from
Jul 28, 2022

Conversation

rsanchez15
Copy link
Contributor

@rsanchez15 rsanchez15 commented Jul 28, 2022

There was a datarace caused by deleting the builtinprotocols of the RTPSParticipant when it was being disabled while the same builtinprotocols were being updated by the file watcher. This fix prevents the file watcher from iterating over the participant being deleted by first removing it from the RTPSDomain participant list and subsequently disabling it.

Description

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added.
  • Any new/modified methods have been properly documented using Doxygen.
  • Fast DDS test suite has been run locally.
  • Changes are ABI compatible.
  • Changes are API compatible.
  • Documentation builds and tests pass locally.
  • New feature has been added to the versions.md file (if applicable).
  • New feature has been documented/Current behavior is correctly described in the documentation.

Reviewer Checklist

  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

…omain participants list

Signed-off-by: RaulSanchez <raul@eprosima.com>
@rsanchez15 rsanchez15 changed the title Disable RTPSParticipantImpl after removing it from RTPSDomain participants list Disable RTPSParticipantImpl after removing it from RTPSDomain participants list [15313] Jul 28, 2022
src/cpp/rtps/RTPSDomain.cpp Outdated Show resolved Hide resolved
Signed-off-by: RaulSanchez <raul@eprosima.com>
Copy link
Member

@MiguelCompany MiguelCompany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI

@MiguelCompany
Copy link
Member

@richiprosima Please test this

@MiguelCompany MiguelCompany merged commit 36818f2 into master Jul 28, 2022
@MiguelCompany MiguelCompany deleted the tsan/disable-rtps-part branch July 28, 2022 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants