Disable RTPSParticipantImpl after removing it from RTPSDomain participants list [15313] #2892
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a datarace caused by deleting the builtinprotocols of the RTPSParticipant when it was being disabled while the same builtinprotocols were being updated by the file watcher. This fix prevents the file watcher from iterating over the participant being deleted by first removing it from the RTPSDomain participant list and subsequently disabling it.
Description
Contributor Checklist
versions.md
file (if applicable).Reviewer Checklist